Hey,

I already had this feature request in my mind, I'm glad you already got a working state. I made a few annotations to the source code, but in general the PR looks good to me.

I added a field in the comment table, is this something that will prevent you to merge this feature ?

Sure, I built a simple schema migration in isso/db/__init__.py where you can add a new column.

Awesome!

I'll make the modifications (notify instead of notification, and update the mail body with the reply link) and dig into the schema migration.

I made the checkbox invisible by default so it only appear once the email is filled, and if email is left empty it never appear. Do you think it's better to always display it ?

I actually meant that a change in the schema is not a reason to not merge ;) SQLite3 can add new columns without any migration code.

I made the checkbox invisible by default so it only appear once the email is filled, and if email is left empty it never appear. Do you think it's better to always display it ?

Oh, I've overseen this. I thought the checkbox is not visible at all. It is a good solution then :)

Any news on this?

Would love to have that.

I will update my pull request today, stay tuned!

Any news? :P

I've rebased your PR to the current master but did not finished yet. We've discusses this feature in IRC yesterday and it is more complex than initially thought.

When a user subscribes to further comments, the email might be a fake and is owned by someone else. Hence, there also needs to be an unsubscribe feature as well. Also it is useful to store the user's prefered locale and send localized emails instead of english-only.

Opt-out is not needed, double opt-in would be enough according to the laws. Actually, the user would just have to confirm his mail address by a unique token (or something) before it's added to the database (per article, of course).

any news?

It would be really great to have this feature because I have several places where I would like Isso to replace Disqus..

But my sites are not really something that my commenters are following like hawks, so they would probably never notice that they got a reply, let alone even remember that they visited my sites :P

This feature would be the one that actually made me ditch Disqus completely.

AFAIR other self-hosted comment systems have it, so you could already ditch Disqus...

AFAIR other self-hosted comment systems have it, so you could already ditch Disqus...

So, could I .. let me see: what other self-hosted systems are there that are as good as Isso?
I have found none.

Last time I checked, HashOver (2.0, not "final" yet) seemed to be pretty decent.

Hashover has a license that I don't agree with, and it seems a bit clunky. Especially the interface, which is important to me. But, yes: that is pretty close :)

I don't think it has Disqus import, though.

+1

Not clear why this isn't more urgently being integrated.

Is there anything we could do to help the process? This feature is currently the only thing holding me back from making the transition to isso.

Just to answer @dertuxmalwieder on his message on optout not being needed (yes it's more than 2 years ago :D) → optout links in emails are a legal obligation in France. I think France is not the only country requesting such a link. This PR should implement both double opt-in & optout to be completly ok I think.

Looking forward to this feature. While I can enable email notifications when people comment on my blog, I'd like people to optionally start/stop notifications when people reply to their comments.

What's the status of this? This has been open for awhile and still unmerged. I'm looking at Isso pretty seriously, but this is something that's missing imo.

There is no opt-out, which is a hard requirement before I can consider merging.

I think add a checkbox let user choose send email for his comment be replied or not is a good idea.

Maybe someone cloud resolve the conficts with this branch？

Bump. This is a super feature

I merged this to current master and implemented opt-out using a link in every mail sent. And I made some small additional improvements:

• Fix for a thread problem that popped up, see SMTP thread collision #395.
• Add the new column to database if needed (by simply adding the column in a try statement, maybe there is a nicer way).
• Include a link to the comment itself in the email (as was already done for the admin emails).

There is one thing in this implementation that I'm not happy about, though. If you check the "Subscribe to email notification of replies" checkbox when making a reply, you will never get any notifications, since you can't really reply to a reply. I can see a number of solutions:

1. Don't show the checkbox at all when writing replies.
2. Checking the checkbox for a reply could mean that author gets notifications for all replies to the same parent comment that he/she replied to.
3. Even though the Reply buttons shown after each reply currently has the exact same effect as clicking Reply on the parent comment, it could still be arranged so that notifications are sent based on exactly which Reply button you pressed.

Any preferences on this?

I feel like it should act the same as the parent comment. Thanks for update, testing now

I agree with @rawsh that solution 2 is the most intuitive one. I updated my branch with this behavior.

I think solution 3 provides the best user experience, though it doesn't seem it can be implemented cleanly with the current reply model.

@pellenilsson Maybe you should open another PR to give more visibility to your branch (with a small summary of the remaining issues so people don't have to refer to this PR).

@pellenilsson I would very much appreciate your contribution for my own instance and thus consider merging it soon. This current PR is a bit too much outdated and requires some updates on the latest discussions.

@vincentbernat @blatinier Working on it! I merged with master again (after the Gravatar and Preview additions), but there are some details left to fix. Will create a new PR after that.

That's great news! Thanks for your work in advance

Oh this is awesome!

It is!

Thanks!